Bugfix for min gauge values > 0 #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color locations were off before when the minimum value of a gauge scale was set to a value > 0.
Collaborator
|
Thanks @rolandFleddermann - and apologies that we haven't gotten a chance to review this yet. This repo has had a whole bunch of work added to it a while back that we haven't had a chance yet to QA and release, but I'm hoping we can get to that in the next couple of months! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color locations were off before when the minimum value of a gauge scale was set to a value > 0.
for example in this case
Gauge( id="demoGauge", label="Gauge", logarithmic=False, min=50, max=150, scale={"start": 50, "interval": 10, "labelInterval": 10}, value=100, showCurrentValue=True, color={"gradient": False, "default": "lightblue", "ranges": {"red": [50, 100], "yellow": [100, 110],"green": [110, 150]}} ),before the fix it would render like this:
before:
and after:
Unfortunately the diff does not render all that well, all that happened is that I removed the
if (minimum < 0) {block and changed the indent level inside...